Support build unknown type#210
Merged
Merged
Conversation
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Added validation in the workspace generation process to enforce limits on single file size (128GB), maximum file count (1024), and total workspace size (8TB). Included unit tests to verify these constraints. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
… validation Implemented comprehensive unit tests for the `generateByModelConfig` and `generateByConfig` methods, ensuring correct handling of various model configuration scenarios. Enhanced the `validateWorkspace` method tests to cover edge cases, including empty directories and symbolic links. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Updated the command-line flag for ignoring unrecognized file types to mark it as deprecated and hidden, indicating it will be removed in the next release. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
… limits Consolidated file size thresholds and workspace limits into a single constants block for improved readability and maintainability. Updated comments for clarity on each constant's purpose. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Updated file size constants to utilize the go-humanize package for improved readability and maintainability. Adjusted the formatBytes function to leverage humanize.Bytes for converting byte sizes to a human-readable format. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Updated the MaxWorkspaceFileCount constant to allow for a higher limit of files in the workspace, enhancing flexibility for users managing larger projects.
SAY-5
added a commit
to SAY-5/modctl
that referenced
this pull request
May 2, 2026
* feat: support handle unknown file type * feat: add support for distributed checkpoint file format * feat: expand supported file formats for config * feat: expand supported file formats for weight * feat: expand supported file formats for code * feat: expand supported file formats for doc * feat: implement workspace limits for file size, count, and total size Added validation in the workspace generation process to enforce limits on single file size (128GB), maximum file count (1024), and total workspace size (8TB). Included unit tests to verify these constraints. * feat: add unit tests for model configuration generation and workspace validation Implemented comprehensive unit tests for the `generateByModelConfig` and `generateByConfig` methods, ensuring correct handling of various model configuration scenarios. Enhanced the `validateWorkspace` method tests to cover edge cases, including empty directories and symbolic links. * feat: deprecate and hide the ignore-unrecognized-file-types flag Updated the command-line flag for ignoring unrecognized file types to mark it as deprecated and hidden, indicating it will be removed in the next release. * refactor: reorganize constants for file size thresholds and workspace limits Consolidated file size thresholds and workspace limits into a single constants block for improved readability and maintainability. Updated comments for clarity on each constant's purpose. * refactor: replace hardcoded byte size constants with humanize package Updated file size constants to utilize the go-humanize package for improved readability and maintainability. Adjusted the formatBytes function to leverage humanize.Bytes for converting byte sizes to a human-readable format. * fix: revert error message for existing modelfile check * chore: increase maximum workspace file count from 1024 to 2048 Updated the MaxWorkspaceFileCount constant to allow for a higher limit of files in the workspace, enhancing flexibility for users managing larger projects. --------- Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.